Add a note about installing the library with cget#954
Merged
Conversation
Contributor
Author
|
The failures on travis seems unrelated to this. |
nlohmann
requested changes
Feb 4, 2018
nlohmann
left a comment
nlohmann
left a comment
Owner
There was a problem hiding this comment.
- "the latest" -> "the latest version"
- "(ie
cget install nlohmann/json -DJSON_MultipleHeaders=ON)" -> "(i.e.,cget install nlohmann/json -DJSON_MultipleHeaders=ON)"
Owner
|
@pfultz2 Could you address the requested changes, please? |
Contributor
Author
This actually installs the latest from develop, so it is the latest version, but not the latest released version. |
Owner
|
I just made that comment because the previous sentence missed a word. Maybe "the latest development version"? Furthermore, there is a space missing after "flag". |
Contributor
Author
Sure, that works.
Got it. |
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a note about installing with
cgetsince its already supported(due to supporting cmake installation out of the box).