Skip to content

Fix issue #1805#1806

Merged
nlohmann merged 1 commit into
nlohmann:developfrom
cbegue:develop
Nov 1, 2019
Merged

Fix issue #1805#1806
nlohmann merged 1 commit into
nlohmann:developfrom
cbegue:develop

Conversation

@cbegue

@cbegue cbegue commented Oct 21, 2019

Copy link
Copy Markdown
Contributor
  • Add some restriction on pair partial specialization of to_json

Signed-off-by: Camille Bégué camille.begue.pro@gmail.com

@coveralls

coveralls commented Oct 21, 2019

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling 794a3d4 on cbegue:develop into f272ad5 on nlohmann:develop.

@nlohmann nlohmann left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only have a small remark on the test case.

Comment thread test/src/unit-udt.cpp Outdated
 * Add some restriction on pair partial specialization of to_json

Signed-off-by: Camille Bégué <camille.begue.pro@gmail.com>

@nlohmann nlohmann left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann self-assigned this Nov 1, 2019
@nlohmann nlohmann added this to the Release 3.7.1 milestone Nov 1, 2019
@nlohmann nlohmann merged commit a1828bb into nlohmann:develop Nov 1, 2019
@nlohmann

nlohmann commented Nov 1, 2019

Copy link
Copy Markdown
Owner

Thanks!

@nlohmann

nlohmann commented Nov 1, 2019

Copy link
Copy Markdown
Owner

🔖 Release item

This issue/PR will be part of the next release of the library. This template helps preparing the release notes.

Type

  • ✨ New Feature
  • 🐛 Bug Fix
  • ⚡️ Improvement
  • 🔨 Further Change
  • 🔥 Deprecated function

Description

  • Fixed the specialization for conversions from pairs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants