feat(node-server): support listening to unix sockets using NITRO_UNIX_SOCKET - #1201
Merged
Conversation
✅ Live Preview ready!
|
NITRO_SOCKET
Codecov Report
@@ Coverage Diff @@
## main #1201 +/- ##
==========================================
- Coverage 77.89% 77.80% -0.09%
==========================================
Files 76 76
Lines 7816 7816
Branches 800 797 -3
==========================================
- Hits 6088 6081 -7
- Misses 1726 1732 +6
- Partials 2 3 +1 |
pi0
approved these changes
Aug 20, 2023
pi0
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR. I have updated implementation to be simplified and also support TLS sockets.
NITRO_SOCKETNITRO_SOCKET
NITRO_SOCKETNITRO_UNIX_SOCKET
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Resolves #1129
❓ Type of change
📚 Description
This PR implements the mechanism necessary to serve over the UNIX domain socket.
📝 Checklist