Support for recurring tasks#3021
Conversation
|
Thanks a lot. This seems to be a new implementation, not based on #2318, right? |
|
@raimund-schluessler Wasn't aware of #2318, its a new implementation, will add some a proper description later on, about how different tools (Thunderbird, Apple Calendar) are handling the recurring tasks, how this is done here. The markup part is mostly copied from the calendar. |
schulm
changed the title
|
Just loaded this manually and it seems to work on first impression. I'll let it run for a while to see if I find any issues. Thank you so so so much! |
|
Thanks, this has worked well in testing. However I get an error from the ical lib when |
|
@tjbp Can you elaborate on the error? |
|
I also have a little bit of feedback regarding the selection dialog for reccurrence, if you are interested. It would be pretty handy to have different parameters, depending on which type of reccurance you select. As inspiration I have also included examples from the Tasks.org Android app, which I personally find extraordinarily intuitive.
This is my opinion at least, but I am open to discuss this further. And of course, thanks for working on this! |
|
@devn1x @tjbp @asavageiv |
|
@schulm you should not add the translations yourself, the translation community will do this automatically once this PR is merged. Also I assume that they are AI generated, which can often lead to wrong translations due to missing context. |
Correct, translations are handled on Transifex and synced to the repo automatically once the PR is merged. |
|
So I just revert my changes from in |
Yes, you should drop all changes to the files in |
|
BTW if this duplicates code from the calendar app, it probably makes sense to talk to the Calendar app maintainers and create a shared library both apps can use. |
|
@schulm: I looked at it locally and at first glance it looks really good. If I had to say something regarding the ui, I would only mention that the alignment between components sometimes feels a little off. E.g. (maybe you wanted to push the dropdown to a new line?): Sadly, I hadn't had the time to check it functionality wise. But you see, this is now small stuff. I think it was a really good idea to copy the design from the calendar. |
|
@devn1x This modal is now aligned with the calendar one. |
|
Nice. That looks better. While testing I noticed, that when I select the checkbox "On the", it shifts to the right. Before: I also have question. When you select "On the" first "day" like this, isn't this redundant to "On a specific day"? Although this applies to the calendar as well. |
|
@devn1x fixed the "On the" container (also full width) Yes its redundand, but maybe you need the option for example for "every second to last day", so it will work for month with different lengths... |
|
Oh right, that could indeed be helpful. Thanks. I tested again with the latest version and now it behaves like this, which is rather interesting: |
|
@devn1x That doesn't look like my current changes, the list of days should have full width. Maybe a browser cache issue? 
|
|
Oh sorry, you are right. Now it looks better. Thanks! It seems there is nothing that jumps out at me right now. |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
|
@schulm Otherwise, I also had another idea for possible improvement. In my use cases, it's really helpful to identify recurring Tasks in the list view at a glance. Maybe it would make sense to add some kind of indicator in the list of tasks. Maybe like the icon that gets displayed, when the description is filled? What do you think? |
|
@devn1x I've changed the visibility of the RecurrenceItem in the sidebar, its only visible if a task has a start date, this is also done by other task apps. Also I've added a recurring icon in the task list. Update: there is still somehow an issue there... |
|
For now I don't know what else there could be. It would be really interesting to hear the opinion from one of the maintainers. They of course must be happy as well for it to be merged :) |
|
I am definitely very happy that this has been tackeled. Thanks a lot @schulm! I will hopefully have time to have a look at the weekend. |
|
@raimund-schluessler Any update? |
|
@schulm I had a look now. It seems to work as far as I can tell from the short time I tested it yet. Thanks a lot! However, there are some lint errors. Most of them are cosmetic (more or less) and due to the fact that the code was copied from Calendar, which still uses vue 2 (Tasks uses vue 3). But a few lint problems are actual errors, especially the If that is done, I would like to move forward and merge the PR. We should then test it a bit more, including an alpha release of Tasks 0.18.0. |
|
@raimund-schluessler I've done a cleanup |
|
@schulm Thanks a lot for you work, looking forward to see it implemented. |
Implement recurring task functionality including: - Recurrence rule model and UI components (frequency, interval, end conditions) - Weekly, monthly, and yearly recurrence options - Automatic creation of next occurrence when completing a recurring task - RecurrenceItem sidebar component showing recurrence summary - Recurrence rule formatting filter for human-readable display - Unit tests for recurring task logic Fixes nextcloud#34 Signed-off-by: Martin Schulze <schulm@outlook.com>
|
@manfredu done |
|
|
@schulm I am going to merge this now. Thank you very much for this very welcome and big contribution. As this implements a very long requested feature, I would like to test it for a while to collect feedback how it works, especially in combination with other clients. I will create an alpha release to make testing easier. |
|
@schulm you are the goat! Thank goodness for getting this through! You too @raimund-schluessler |
|
Thank you so much @schulm , I'm testing and so far so good in 33.0 <3 |
|
A few people were offering some money to implement this feature: |
|
This is fantastic. I just checked and confirmed that this has been merged into nextcloud:main. As @corbin-auriti, a bunch of us offered rewards for this work. Looks like it adds up to something over $600 USD. I'm ready to fulfill my part. @schulm, we need some instructions on where to send payment. I can do Paypal and Venmo immediately, and I'm open to any other legit payment platform. Whether you knew about these informal bounties or not, you brought us across the finish line, and you deserve the reward. Please, tell us how to pay off. |
|
@bpmartin20 My Paypal is https://www.paypal.com/paypalme/schulm |
|
Hello, and thank you very much for implementing this! |
|
@raimund-schluessler Can we have a release? |
|
I've been waiting for this since I started my self-hosting journey years ago, can't wait to try it 😍. |
13 participants
Fixes #34