Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/theming/src/components/UserSectionBackground.vue
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ async function pickColor(color?: string) {
async function pickFile() {
await getFilePickerBuilder(t('theming', 'Select a background from your files'))
.allowDirectories(false)
.setFilter((node) => node.mime.startsWith('image/'))
.setFilter((node) => node.type === 'folder' || node.mime?.startsWith('image/'))
.setMultiSelect(false)
.addButton({
label: t('theming', 'Select background'),
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,87 @@
/*!
* SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors
* SPDX-License-Identifier: AGPL-3.0-or-later
*/

import { shallowMount } from '@vue/test-utils'
import { describe, expect, it, vi } from 'vitest'
import UserSectionBackground from '../UserSectionBackground.vue'

type PickerFilter = (node: { type?: string, mime?: string }) => boolean | undefined

const setFilter = vi.hoisted(() => vi.fn<(filter: PickerFilter) => unknown>())

vi.mock('@nextcloud/dialogs', () => ({
getFilePickerBuilder: vi.fn(() => {
const builder = {
allowDirectories: vi.fn(),
setFilter,
setMultiSelect: vi.fn(),
addButton: vi.fn(),
build: vi.fn(),
}

builder.allowDirectories.mockReturnValue(builder)
builder.setFilter.mockReturnValue(builder)
builder.setMultiSelect.mockReturnValue(builder)
builder.addButton.mockReturnValue(builder)
builder.build.mockReturnValue({
pick: vi.fn().mockResolvedValue(undefined),
})

return builder
}),
}))

vi.mock('@nextcloud/initial-state', () => ({
loadState: vi.fn((_app: string, key: string) => {
switch (key) {
case 'shippedBackgrounds':
return {}
case 'themingDefaults':
return {
backgroundImage: '',
backgroundColor: '#ffffff',
backgroundMime: '',
defaultShippedBackground: '',
}
case 'data':
return {
backgroundImage: '',
backgroundColor: '#ffffff',
backgroundMime: '',
}
case 'userBackgroundImage':
return 'default'
default:
throw new Error(`Unexpected initial state key: ${key}`)
}
}),
}))

vi.mock('@nextcloud/l10n', () => ({
t: (_app: string, text: string) => text,
}))

describe('UserSectionBackground', () => {
it('keeps folders and images while filtering other files', async () => {
const wrapper = shallowMount(UserSectionBackground, {
global: {
stubs: {
NcSettingsSection: {
template: '<section><slot /></section>',
},
},
},
})

await wrapper.get('button[aria-label="Custom background"]').trigger('click')

expect(setFilter).toHaveBeenCalledOnce()
const filter = setFilter.mock.calls[0]![0]
expect(filter({ type: 'folder' })).toBe(true)
expect(filter({ mime: 'image/png' })).toBe(true)
expect(filter({ mime: 'text/plain' })).toBe(false)
expect(filter({})).toBeFalsy()
})
})