fix(s3): show S3 error messages in the frontend#62163
Open
mejo- wants to merge 1 commit into
Open
Conversation
Improves error messages on move/copy operations when bucket quota exceeded Fixes: #58801 Signed-off-by: Jonas <jonas@freesources.org>
mejo-
requested review from
Altahrim,
ArtificialOwl,
icewind1991 and
salmart-dev
github-project-automation
Bot
moved this to 🧭 Planning evaluation (don't pick)
in 📝 Productivity team
mejo-
moved this from 🧭 Planning evaluation (don't pick)
to 👀 In review
in 📝 Productivity team
Member
Author
|
/backport to stable34 |
cuppett
approved these changes
Jul 15, 2026
CarlSchwan
reviewed
Jul 15, 2026
| throw new \Sabre\DAV\Exception\Forbidden(''); | ||
| } | ||
| } catch (StorageNotAvailableException $e) { | ||
| } catch (StorageNotAvailableException|S3Exception $e) { |
Member
There was a problem hiding this comment.
This seems to be the wrong layer to expose this sort of error. This should be catched in lib/private/Files/ObjectStore/ObjectStoreStorage::rename and converted to a NotPermittedException with a more user friendly error message
CarlSchwan
reviewed
Jul 15, 2026
| $this->writeStream($targetInternalPath, $source); | ||
| $result = true; | ||
| } catch (S3Exception $e) { | ||
| Server::get(LoggerInterface::class)->warning('Failed to copy stream to storage', ['exception' => $e]); |
Member
There was a problem hiding this comment.
same here, ObjectStoreStorage should not throw a S3Exception but a NotPermittedException
CarlSchwan
requested changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves error messages on move/copy operations when bucket quota exceeded
Fixes: #58801
Screenshots
Checklist
3. to review, feature component)stable32)