Skip to content

fix(files_sharing): preserve unmasked permissions as scan_permissions#61905

Merged
solracsf merged 1 commit into
masterfrom
fix/files-sharing-scan-permissions
Jul 16, 2026
Merged

fix(files_sharing): preserve unmasked permissions as scan_permissions#61905
solracsf merged 1 commit into
masterfrom
fix/files-sharing-scan-permissions

Conversation

@solracsf

@solracsf solracsf commented Jul 8, 2026

Copy link
Copy Markdown
Member

Summary

Cache::formatCacheEntry now preserves the unmasked permissions in scan_permissions before applying the share mask, exactly like CachePermissionsMask and the PermissionsMask storage wrapper already do

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
@solracsf solracsf added this to the Nextcloud 35 milestone Jul 8, 2026
@solracsf solracsf requested a review from a team as a code owner July 8, 2026 09:35
@solracsf solracsf requested review from ArtificialOwl, CarlSchwan, come-nc and leftybournes and removed request for a team July 8, 2026 09:35
@solracsf

solracsf commented Jul 8, 2026

Copy link
Copy Markdown
Member Author

/backport to stable34

@solracsf

solracsf commented Jul 8, 2026

Copy link
Copy Markdown
Member Author

/backport to stable33

@solracsf solracsf enabled auto-merge July 9, 2026 09:19
@solracsf solracsf merged commit 9a23b75 into master Jul 16, 2026
273 of 281 checks passed
@solracsf solracsf deleted the fix/files-sharing-scan-permissions branch July 16, 2026 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug community pull requests from community feature: sharing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot change a share link's permissions on items inside a Team folder (updateShare fails with "Cannot increase permissions")

3 participants