Skip to content

fix(files_sharing): 500 on /download link redirect#61015

Closed
ShGKme wants to merge 1 commit into
masterfrom
fix/download-redirect
Closed

fix(files_sharing): 500 on /download link redirect#61015
ShGKme wants to merge 1 commit into
masterfrom
fix/download-redirect

Conversation

@ShGKme

@ShGKme ShGKme commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Summary

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@ShGKme ShGKme added this to the Nextcloud 35 milestone Jun 5, 2026
@ShGKme ShGKme requested review from nfebe and susnux June 5, 2026 14:36
@ShGKme ShGKme self-assigned this Jun 5, 2026
@ShGKme ShGKme requested a review from a team as a code owner June 5, 2026 14:36
@ShGKme ShGKme requested review from ArtificialOwl and artonge and removed request for a team June 5, 2026 14:36
@ShGKme ShGKme added the bug label Jun 5, 2026
@ShGKme ShGKme requested a review from leftybournes June 5, 2026 14:36
@ShGKme ShGKme added 3. to review Waiting for reviews feature: sharing labels Jun 5, 2026
@ShGKme

ShGKme commented Jun 5, 2026

Copy link
Copy Markdown
Contributor Author

/backport to stable34

@ShGKme

ShGKme commented Jun 5, 2026

Copy link
Copy Markdown
Contributor Author

/backport to stable33

@ShGKme

ShGKme commented Jun 5, 2026

Copy link
Copy Markdown
Contributor Author

/backport to stable32

@ShGKme

ShGKme commented Jun 5, 2026

Copy link
Copy Markdown
Contributor Author

/backport to stable31

@ShGKme

ShGKme commented Jun 5, 2026

Copy link
Copy Markdown
Contributor Author

/backport! to stable31

@backportbot

backportbot Bot commented Jun 5, 2026

Copy link
Copy Markdown

The backport to stable31 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable31
git pull origin stable31

# Create the new backport branch
git checkout -b backport/61015/stable31

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 16db9265

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/61015/stable31

Error: Failed to check for changes with origin/stable31: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@ShGKme ShGKme changed the title fix(files_staring): 500 on /download link redirect fix(files_sharing): 500 on /download link redirect Jun 5, 2026
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme force-pushed the fix/download-redirect branch from 16db926 to e4c2625 Compare June 5, 2026 15:18
@ShGKme

ShGKme commented Jun 5, 2026

Copy link
Copy Markdown
Contributor Author
  • fixed a typo in a commit message

@ShGKme

ShGKme commented Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

This change may not be needed on Nextcloud 32 and above.

That PR (accidentally?) added support for /public.php/dav/files/TOKEN? links by changing the baseuri to just /public.php/dav/.

@provokateurin Was it intentional?

I'm unsure if we still need this change, or we officially support links without the trailing slash in dav...

@ShGKme ShGKme changed the title fix(files_sharing): 500 on /download link redirect https://github.com/nextcloud/server/pull/61016 Jun 8, 2026
@ShGKme ShGKme changed the title https://github.com/nextcloud/server/pull/61016 fix(files_sharing): 500 on /download link redirect Jun 8, 2026
@ShGKme ShGKme closed this Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants