fix(occ): set GID before UID to ensure success#60331
Merged
Merged
Conversation
The previous implementation attempted to set GID after dropping root UID, which would fail (silently) and made the posix_setgid() call effectively a no-op. This swaps the order to set the target GID first. Also refactored for clarity: - Renamed dropPrivileges to switchToConfigFileOwner for clearer intent - Update docblock to explicitly state best-effort limitations - Use more descriptive variable names - Re-organized for readability Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
requested review from
Altahrim,
ArtificialOwl and
icewind1991
and removed request for
a team
provokateurin
approved these changes
May 13, 2026
Merged
Closed
come-nc
approved these changes
Jun 11, 2026
come-nc
added
4. to release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The previous implementation attempted to set GID after dropping root UID, which would fail (silently) and made the
posix_setgid()call effectively a no-op. This swaps the order to set the target GID first.Also refactored for clarity:
dropPrivilegestoswitchToConfigFileOwnerfor clearer intentTODO
Checklist
3. to review, feature component)stable32)AI (if applicable)