Skip to content

chore: Increase page load timeout for oracle setup tests#60023

Merged
artonge merged 1 commit into
masterfrom
fix/fix-oracle-setup-tests
May 7, 2026
Merged

chore: Increase page load timeout for oracle setup tests#60023
artonge merged 1 commit into
masterfrom
fix/fix-oracle-setup-tests

Conversation

@come-nc

@come-nc come-nc commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

Summary

Fix this kind of failures:
Copie d'écran_20260430_180738

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@come-nc come-nc added this to the Nextcloud 34 milestone Apr 30, 2026
@come-nc come-nc self-assigned this Apr 30, 2026
@come-nc come-nc added 3. to review Waiting for reviews CI labels Apr 30, 2026
@come-nc

come-nc commented Apr 30, 2026

Copy link
Copy Markdown
Contributor Author

✓ Oracle (54664ms)

It was "fast" so I cannot know if the change worked 😢

@come-nc come-nc marked this pull request as ready for review April 30, 2026 16:24
@come-nc come-nc requested a review from a team as a code owner April 30, 2026 16:24
@come-nc come-nc requested review from nfebe, sorbaugh and susnux and removed request for a team April 30, 2026 16:24

@susnux susnux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this a fix? It does not even touch the setup tests?
For setup tests just add Cypress.config('pageLoadTimeout', 100000)

@come-nc

come-nc commented May 4, 2026

Copy link
Copy Markdown
Contributor Author

How is this a fix? It does not even touch the setup tests? For setup tests just add Cypress.config('pageLoadTimeout', 100000)

I pushed the wrong thing it seems

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc force-pushed the fix/fix-oracle-setup-tests branch from 649262f to e4b05d3 Compare May 4, 2026 07:30
@come-nc

come-nc commented May 4, 2026

Copy link
Copy Markdown
Contributor Author

/backport to stable33

@come-nc come-nc requested a review from susnux May 4, 2026 08:03
@come-nc come-nc added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 4, 2026
@artonge

artonge commented May 7, 2026

Copy link
Copy Markdown
Collaborator

Cypress failure unrelated

@artonge artonge merged commit b468f90 into master May 7, 2026
140 of 144 checks passed
@artonge artonge deleted the fix/fix-oracle-setup-tests branch May 7, 2026 10:50
This was referenced May 7, 2026
This was referenced May 15, 2026
@come-nc

come-nc commented Jun 15, 2026

Copy link
Copy Markdown
Contributor Author

/backport to stable32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants