Skip to content

feat(files): render file list filters in top bar and allow to collapse into overflow menu#57664

Merged
susnux merged 6 commits into
masterfrom
feat/filters
Jan 22, 2026
Merged

feat(files): render file list filters in top bar and allow to collapse into overflow menu#57664
susnux merged 6 commits into
masterfrom
feat/filters

Conversation

@susnux

@susnux susnux commented Jan 20, 2026

Copy link
Copy Markdown
Contributor

Summary

Bildschirmaufnahme_20260120_175439.webm

Checklist

@susnux susnux added this to the Nextcloud 33 milestone Jan 20, 2026
@susnux susnux requested review from a team and skjnldsv as code owners January 20, 2026 15:43
@susnux susnux requested review from nfebe and szaimen and removed request for a team January 20, 2026 15:43
@susnux susnux self-assigned this Jan 20, 2026
@github-project-automation github-project-automation Bot moved this to 🏗️ In progress in 📁 Files team Jan 20, 2026
Comment thread apps/files/src/components/BreadCrumbs.vue Outdated
Comment thread apps/files/src/components/BreadCrumbs.vue
Comment thread apps/files/src/components/FilesListTableHeaderActions.vue

@nfebe nfebe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some inline comments

@susnux susnux requested a review from nfebe January 21, 2026 13:09
@susnux susnux requested a review from a team as a code owner January 21, 2026 14:05
@szaimen

szaimen commented Jan 21, 2026

Copy link
Copy Markdown
Contributor

I just tested this and the new button seems to vanish completely on narrow screens in the latest iteration:

Aufzeichnung.2026-01-21.151441.mp4

@susnux

susnux commented Jan 21, 2026

Copy link
Copy Markdown
Contributor Author

@szaimen fixed in the latest commit:

Bildschirmaufnahme_20260121_153301.webm

@szaimen szaimen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@szaimen fixed in the latest commit:

Bildschirmaufnahme_20260121_153301.webm

LGTM then, thanks ☺️

@susnux

susnux commented Jan 22, 2026

Copy link
Copy Markdown
Contributor Author

/backport to stable33

kra-mo
kra-mo previously requested changes Jan 22, 2026

@kra-mo kra-mo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

I seem to have a bit of trouble actually testing this branch, but a couple of comments from the screen recordings:

  • The "Back to filters" button should be tertiary.
  • Is there any gap between the New button and the path bar? There should be some. If yes, no problem :)
  • The "Search everywhere" button looks quite cramped there. Maybe just increase its border radius?
  • It would be good to expose all folder actions in the dropdown in the path bar, this was a feature request. I'm guessing this is out of scope for this PR, but a new issue should be opened, then.

@susnux

susnux commented Jan 22, 2026

Copy link
Copy Markdown
Contributor Author
  • The "Back to filters" button should be tertiary.

✅ fixed

  • Is there any gap between the New button and the path bar? There should be some. If yes, no problem :)

Yes all elements in that row have a gap of default grid baseline.

  • The "Search everywhere" button looks quite cramped there. Maybe just increase its border radius?

Needs to be fixed then in components - nothing special applied here :)

  • It would be good to expose all folder actions in the dropdown in the path bar, this was a feature request. I'm guessing this is out of scope for this PR, but a new issue should be opened, then.

Yes thats not part of the linked issue and should be done separately.

…oint

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux dismissed kra-mo’s stale review January 22, 2026 15:34

review points addressed

@susnux susnux merged commit e5c08cc into master Jan 22, 2026
145 of 150 checks passed
@susnux susnux deleted the feat/filters branch January 22, 2026 20:15
@susnux

susnux commented Jan 22, 2026

Copy link
Copy Markdown
Contributor Author

/backport to stable33

1 similar comment
@susnux

susnux commented Jan 23, 2026

Copy link
Copy Markdown
Contributor Author

/backport to stable33

@kra-mo

kra-mo commented Jan 23, 2026

Copy link
Copy Markdown
Member

Needs to be fixed then in components - nothing special applied here :)

Shall I open an issue?

Yes thats not part of the linked issue and should be done separately.

Well, the part of

It should contain actions you can take on the folder

but I wasn't clear anyway and it doesn't really matter, I will open a new issue :)

@susnux

susnux commented Jan 23, 2026

Copy link
Copy Markdown
Contributor Author

Shall I open an issue?

Please go ahead, will then look into implementation :)

@kra-mo

kra-mo commented Jan 23, 2026

Copy link
Copy Markdown
Member

Opened #57752 and nextcloud-libraries/nextcloud-vue#8117

@sorbaugh sorbaugh moved this from 🏗️ In progress to ☑️ Done in 📁 Files team Jan 26, 2026
@nextcloud-bot nextcloud-bot mentioned this pull request Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: ☑️ Done

Development

Successfully merging this pull request may close these issues.

Files app toolbar design adjustment

7 participants