Skip to content

[stable29] fix: filter out contacts with empty email addresses in sharee completion #51710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusknorr merged 2 commits into from
Mar 28, 2025
Merged

[stable29] fix: filter out contacts with empty email addresses in sharee completion #51710

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9edeec2
fix: filter out contacts with invalid email addresses in sharee compl…
juliusknorr Mar 25, 2025
fc7ac7b
test: Adapt tests to properly use valid email addresses
juliusknorr Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/private/Collaboration/Collaborators/MailPlugin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,11 @@ public function search($search, $limit, $offset, ISearchResult $searchResult): b
$emailAddress = $emailAddressData['value'];
$emailAddressType = $emailAddressData['type'];
}

if (!filter_var($emailAddress, FILTER_VALIDATE_EMAIL)) {
continue;
}

if (isset($contact['FN'])) {
$displayName = $contact['FN'] . ' (' . $emailAddress . ')';
}
Expand Down