Skip to content

fix(oc-dialog): Get rid of the overlay #44717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
susnux merged 2 commits into from
Apr 8, 2024
Merged

fix(oc-dialog): Get rid of the overlay #44717

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e136c3
fix(oc-dialog): Get rid of the overlay
JED-B Apr 5, 2024
cfaaff1
chore(assets): Recompile assets
nextcloud-command Apr 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/src/jquery/css/jquery.ocdialog.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
border-radius: var(--border-radius-large);
box-shadow: 0 0 30px var(--color-box-shadow);
padding: 24px;
z-index: 10000;
z-index: 100001;
font-size: 100%;
box-sizing: border-box;
min-width: 200px;
Expand Down Expand Up @@ -69,7 +69,7 @@
.oc-dialog-dim {
background-color: #000;
opacity: .2;
z-index: 9999;
z-index: 100001;
position: fixed;
top: 0;
left: 0;
Expand Down
2 changes: 1 addition & 1 deletion core/src/jquery/ocdialog.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ $.widget('oc.ocdialog', {
}
this.overlay = $('<div>')
.addClass('oc-dialog-dim')
.appendTo(contentDiv)
.insertBefore(this.$dialog)
this.overlay.on('click keydown keyup', function(event) {
if (event.target !== self.$dialog.get(0) && self.$dialog.find($(event.target)).length === 0) {
event.preventDefault()
Expand Down