Fix AppSettingsController.php overwriting currentLanguage#42044
Merged
Conversation
Fix for CurrentLanguage being overwritten by currentVersion thus breaking App-View Signed-off-by: 1 Man Projects <reed@1manprojects.de>
8 tasks
kesselb
reviewed
Dec 5, 2023
kesselb
left a comment
kesselb
left a comment
Contributor
There was a problem hiding this comment.
Wow, this has been sitting in our code for quite a while now ;)
juliusknorr
approved these changes
Dec 5, 2023
This comment was marked as resolved.
This comment was marked as resolved.
Member
|
/backport to stable28 |
Member
|
/backport to stable27 |
Member
|
/backport to stable26 |
Member
|
/backport to stable28 |
Member
|
/backport to stable27 |
4 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for currentLanguage being overwritten by currentVersion thus breaking App-View
Summary
Fixes Issue where the currentLanguage is being overwritten in certain cases by the currentVersion of the App thus breaking the App View in Nextcloud.
Checklist