Skip to content

removed profile data from LDAP will get removed#37856

Merged
come-nc merged 3 commits into
nextcloud:masterfrom
march42:bugfix/ldap_profiledata_removed
Apr 24, 2023
Merged

removed profile data from LDAP will get removed#37856
come-nc merged 3 commits into
nextcloud:masterfrom
march42:bugfix/ldap_profiledata_removed

Conversation

@march42

@march42 march42 commented Apr 21, 2023

Copy link
Copy Markdown
Contributor

If attribute mapping is configured and no value present in LDAP, the according profile field is emptied. Removing an attribute e.g. phone from LDAP will cause the phone number being removed from profile.

Summary

  1. Removing an attribute from LDAP will empty the profile field for this user
  2. Setting an nonexisting attribute will empty the corresponding profile field for all users

TODO

  • checked different scenarios

Checklist

If attribute mapping is configured and no value present in LDAP, the
according profile field is emptied. Removing an attribute e.g. phone
from LDAP will cause the phone number being removed from profile.

Signed-off-by: Marc Hefter <marchefter@gmail.com>
@march42

march42 commented Apr 21, 2023

Copy link
Copy Markdown
Contributor Author

Sorry I missied this before. hopefully @come-nc @Pytal @szaimen can review this fix.

@szaimen szaimen added this to the Nextcloud 27 milestone Apr 21, 2023
@szaimen szaimen added the 3. to review Waiting for reviews label Apr 21, 2023
@szaimen szaimen requested review from a team, ArtificialOwl, blizzz and come-nc and removed request for a team April 21, 2023 12:40
@szaimen szaimen added the bug label Apr 21, 2023

@come-nc come-nc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved apart from codestyle comment.

Comment thread apps/user_ldap/lib/User/User.php Outdated
march42 and others added 2 commits April 24, 2023 10:14
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Marc Hefter <marchefter@march42.net>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Marc Hefter <marchefter@march42.net>
@come-nc come-nc merged commit e8a48b5 into nextcloud:master Apr 24, 2023
@march42 march42 deleted the bugfix/ldap_profiledata_removed branch April 27, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants