Revert "Update guzzlehttp/guzzle requirement from 6.5.2 to 6.5.3 in /build/integration"#20594
Merged
rullzer merged 1 commit intoApr 22, 2020
Conversation
nickvergessen
approved these changes
Apr 22, 2020
nickvergessen
requested changes
Apr 22, 2020
nickvergessen
left a comment
nickvergessen
left a comment
Member
There was a problem hiding this comment.
Please commit the composer.lock too
Member
Author
|
Lets fix that all after the tests pass again ;) |
Merged
…build/integration"
rullzer
force-pushed
the
revert-20554-dependabot/composer/build/integration/guzzlehttp/guzzle-6.5.3
branch
from
71f22ea to
3fc66a6
Compare
danxuliu
approved these changes
Apr 22, 2020
danxuliu
left a comment
danxuliu
left a comment
Member
There was a problem hiding this comment.
Fixes the integration-remote-api tests 👍 Other test failures are unrelated.
The issue seemed to be a mismatch between the Guzzle version in /build/integration and the one in /3rdparty. I do not know if there is an automatic way to keep both in sync.
Member
Author
Yeah shitty php stuff |
rullzer
deleted the
revert-20554-dependabot/composer/build/integration/guzzlehttp/guzzle-6.5.3
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #20554