Skip to content

ellipsize sharee name to not overlap with can edit option on mobile#1774

Merged
MorrisJobke merged 1 commit into
masterfrom
ellipsize-sharee
Oct 18, 2016
Merged

ellipsize sharee name to not overlap with can edit option on mobile#1774
MorrisJobke merged 1 commit into
masterfrom
ellipsize-sharee

Conversation

@jancborchardt

Copy link
Copy Markdown
Member

Before (even worse with longer names, overlapping the text)
capture du 2016-10-18 11-16-52
After
capture du 2016-10-18 11-16-28

Please review @nextcloud/designers

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
@jancborchardt jancborchardt added bug design Design, UI, UX, etc. 3. to review Waiting for reviews labels Oct 18, 2016
@jancborchardt jancborchardt added this to the Nextcloud 11.0 milestone Oct 18, 2016
@mention-bot

Copy link
Copy Markdown

@jancborchardt, thanks for your PR! By analyzing the history of the files in this pull request, we identified @luckydonald, @DeepDiver1975 and @MorrisJobke to be potential reviewers.

@skjnldsv

Copy link
Copy Markdown
Member

👍

@MorrisJobke

Copy link
Copy Markdown
Member

This only works for english 😢 (and for small screens)

bildschirmfoto 2016-10-18 um 14 48 36

bildschirmfoto 2016-10-18 um 14 49 18
bildschirmfoto 2016-10-18 um 14 49 22

@nickvergessen

Copy link
Copy Markdown
Member

On non mobile we should add a tooltip

@MorrisJobke

Copy link
Copy Markdown
Member

Because this already properly fixes one of the issues 👍

CI is finished but the status isn't updated properly -> merge

@MorrisJobke MorrisJobke merged commit d366b0e into master Oct 18, 2016
@MorrisJobke MorrisJobke deleted the ellipsize-sharee branch October 18, 2016 15:03
@jancborchardt

Copy link
Copy Markdown
Member Author

Thx, will fix the desktop view in a separate PR :)

@luckydonald

Copy link
Copy Markdown
Contributor

I'm quite confused, why am I notified here?

@nickvergessen

Copy link
Copy Markdown
Member

Because you mostlikely changed code in the same place as this PR. If you dont want to be notified anymore, we can add you to the ignore list

@luckydonald

Copy link
Copy Markdown
Contributor

I never cotributed to this project i think. Thats why i am so confused.

@MorrisJobke

Copy link
Copy Markdown
Member

I never cotributed to this project i think. Thats why i am so confused.

You did in 2014 😉 7fc574c

Git will never forget 😝

@DeepDiver1975

Copy link
Copy Markdown
Contributor

You did in 2014 😉 7fc574c

owncloud/core#24605 🙊

@luckydonald

luckydonald commented Oct 19, 2016

Copy link
Copy Markdown
Contributor

Oh, I should have seen the similarity to owncloud.
Looked at the readme before and just couldn't figure out where I did something with a "next cloud".
Yay on open source I guess. How is this related to Owncloud?

Edit: Sorry for spamming here. I figured it is already merged, so that wouldn't hurt...

@MorrisJobke

MorrisJobke commented Oct 19, 2016

Copy link
Copy Markdown
Member

How is this related to Owncloud?

Nextcloud is an opensource-only fork of ownCloud 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug design Design, UI, UX, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants