Skip to content

symfony replaced table helper by class, fixes two broken LDAP occ com…#1726

Merged
MorrisJobke merged 1 commit into
masterfrom
fix-symfony-table
Oct 13, 2016
Merged

symfony replaced table helper by class, fixes two broken LDAP occ com…#1726
MorrisJobke merged 1 commit into
masterfrom
fix-symfony-table

Conversation

@blizzz

@blizzz blizzz commented Oct 12, 2016

Copy link
Copy Markdown
Member

…mands

Before:

$ suww ./occ ldap:show-config
[sudo] password for blizzz: 


  [Symfony\Component\Console\Exception\InvalidArgumentException]  
  The helper "table" is not defined.                              


ldap:show-config [--show-password] [--] [<configID>]

Now prints your LDAP config again.

Only master is affected. I I have not seen other usages within the server repo.

Please test and review @nextcloud/ldap @MorrisJobke

…mands

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@mention-bot

Copy link
Copy Markdown

@blizzz, thanks for your PR! By analyzing the history of the files in this pull request, we identified @LukasReschke, @esakol and @owncloud-bot to be potential reviewers.

@rullzer

rullzer commented Oct 13, 2016

Copy link
Copy Markdown
Member

My bad. I gripped for that I think.
Anyways LGTM

@MorrisJobke

Copy link
Copy Markdown
Member

@rullzer could you check for other usage of this table helper? Thanks :)

@MorrisJobke

Copy link
Copy Markdown
Member

Tested and works 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants