Public link, enforce password broken

[schiessle]

I just noticed that the "enforce password" setting for link shares is broken on master.

1. Enable "enforce password" in the admin share settings
2. Try to create a public link
3. On first click nothing happens, also no error messages in the JS console or nextcloud.log
4. Click again on the "+" I get a banner at the top "unable to create a link share", again no additional error message in the logs and the share dialog looks like this:

@skjnldsv could you have a look? Thanks!

[skjnldsv]

@schiessle Hum, this is properly working here.
Can you make sure your cache is cleared?

[schiessle]

@skjnldsv I was confused as well, because I knew that you and @rullzer tested it before we merged the pr. But I can reliable reproduce it here. It is a fresh installation (current master) also opened a private window to make sure no old data are cached.

I tried it with two browsers:

Firefox 63.0.1
Chromium 70.0.3538.67

[skjnldsv]

yep, something else broke it!
Let me handle this