[stable-34.0] fix(file-provider): invalidate lock tokens when file paths change. #10185
Merged
Conversation
WebDAV lock tokens are bound to the path they were issued for. When a parent folder moves, child lock tokens become stale and cause 412/423 upload failures. Clear tokens on rename propagation, server metadata sync, and upload lock errors. Assisted-by: Claude:claude-sonnet-4-5 Signed-off-by: Camila Ayres <hello@camilasan.com>
Assisted-by: Claude:claude-sonnet-4-5 Signed-off-by: Camila Ayres <hello@camilasan.com>
testParent404ReportsParentAsDeleted wrote metadata then awaited the enumerator without holding a Realm reference. Under parallel testing the in-memory store was freed before the enumerator reopened it on another thread, so the materialized-items query came back empty and the 404 parent was never reported deleted. Retain the Realm for each test lifetime. Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Camila Ayres <hello@camilasan.com>
backportbot
Bot
requested review from
camilasan,
i2h3,
mgallien and
nilsding
as code owners
camilasan
approved these changes
Jun 15, 2026
Contributor
|
Artifact containing the AppImage: nextcloud-appimage-pr-10185.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #10135