adjust local controller to better handle permission checks#2522
Merged
Conversation
cristianscheid
force-pushed
the
fix/noid/local-controller-refactor
branch
from
June 15, 2026 16:01
1016287 to
575e2fb
Compare
cristianscheid
changed the title
cristianscheid
changed the title
Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>
cristianscheid
force-pushed
the
fix/noid/local-controller-refactor
branch
from
June 15, 2026 16:51
575e2fb to
ee2e320
Compare
Member
Author
|
/backport to stable34 |
Member
Author
|
/backport to stable33 |
Member
Author
|
/backport to stable32 |
Member
Author
|
/backport to stable31 |
AndyScherzinger
approved these changes
Jun 16, 2026
This was referenced Jun 16, 2026
|
This PR broke circle members listing and adding of members to circles (and likely more) for us in both Nextcloud 32 and 33. The problem is once again nesting and the mess with groups vs circles. We're seeing requests fail for a circle which has only a single member: A group (not a circle). The requests fail for members of that group, as they are part of the circle only via nesting. It's really unfortunate, that PRs like this get backported so handwave-y, and apparently without any testing. :( |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lib/Controller/LocalController.phpChecklist
3. to review, feature component)stable32)AI (if applicable)