Skip to content

Certificate Request for matroskaplayer#1089

Open
davidprojekt wants to merge 1 commit into
nextcloud:masterfrom
davidprojekt:master
Open

Certificate Request for matroskaplayer#1089
davidprojekt wants to merge 1 commit into
nextcloud:masterfrom
davidprojekt:master

Conversation

@davidprojekt

Copy link
Copy Markdown

appid would be matroskaplayer, to be inline with the release name of the library this is based on, which I released under the NPM Namespace @matroska-js

https://github.com/davidprojekt/matroska-player-nextcloud

@davidprojekt

Copy link
Copy Markdown
Author

Also, I want to note — one patent question I'd like your guidance on before this ships.

The app bundles a small audio-only ffmpeg.wasm core (LGPL — built without --enable-gpl / --enable-nonfree) to transcode audio tracks the browser can't decode into royalty-free AAC-LC or Opus. Video is only remuxed, never transcoded. Everything bundled is a decoder; the only encoded output is AAC-LC/Opus.

Most of the bundled decoders are either truly royalty-free (Opus, Vorbis, FLAC, ALAC, WavPack, TTA, PCM) or have clearly-expired core patents (AAC-LC, AC-3).
Two are the borderline cases I want to raise: E-AC-3 and DTS core.
Their core patents appear to have expired, but — unlike AC-3/AAC-LC — that isn't as clean-cut, and both rightsholders are active licensors.
I've deliberately excluded everything clearly still patented (HE-AAC/xHE-AAC, TrueHD/MLP, DTS-HD/MA).

So: are you comfortable with E-AC-3 and DTS-core decoding enabled by default, or would you prefer I drop either/both from the default build? It's a one-line config change, and the app already lets an admin point at a "fuller" external ffmpeg build for anyone who wants extra codecs and accepts the patent responsibility themselves. Happy to match whatever posture you prefer.

@mgallien mgallien left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please fix the failing DCO check ?
For more information, have a look at the failing DCO CI check from the PR
see also our documentation here https://nextcloudappstore.readthedocs.io/en/latest/developer.html#obtaining-a-certificate

@mgallien

Copy link
Copy Markdown
Contributor

Also, I want to note — one patent question I'd like your guidance on before this ships.

The app bundles a small audio-only ffmpeg.wasm core (LGPL — built without --enable-gpl / --enable-nonfree) to transcode audio tracks the browser can't decode into royalty-free AAC-LC or Opus. Video is only remuxed, never transcoded. Everything bundled is a decoder; the only encoded output is AAC-LC/Opus.

Most of the bundled decoders are either truly royalty-free (Opus, Vorbis, FLAC, ALAC, WavPack, TTA, PCM) or have clearly-expired core patents (AAC-LC, AC-3). Two are the borderline cases I want to raise: E-AC-3 and DTS core. Their core patents appear to have expired, but — unlike AC-3/AAC-LC — that isn't as clean-cut, and both rightsholders are active licensors. I've deliberately excluded everything clearly still patented (HE-AAC/xHE-AAC, TrueHD/MLP, DTS-HD/MA).

So: are you comfortable with E-AC-3 and DTS-core decoding enabled by default, or would you prefer I drop either/both from the default build? It's a one-line config change, and the app already lets an admin point at a "fuller" external ffmpeg build for anyone who wants extra codecs and accepts the patent responsibility themselves. Happy to match whatever posture you prefer.

the requirements are on your own
you would already need to ensure that your code is in compliance of the licenses as much as you already checked the codecs and their status

Signed-off-by: David Schneider <git@davidschneider.xyz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants