Certificate Request for matroskaplayer#1089
Conversation
|
Also, I want to note — one patent question I'd like your guidance on before this ships. The app bundles a small audio-only ffmpeg.wasm core (LGPL — built without --enable-gpl / --enable-nonfree) to transcode audio tracks the browser can't decode into royalty-free AAC-LC or Opus. Video is only remuxed, never transcoded. Everything bundled is a decoder; the only encoded output is AAC-LC/Opus. Most of the bundled decoders are either truly royalty-free (Opus, Vorbis, FLAC, ALAC, WavPack, TTA, PCM) or have clearly-expired core patents (AAC-LC, AC-3). So: are you comfortable with E-AC-3 and DTS-core decoding enabled by default, or would you prefer I drop either/both from the default build? It's a one-line config change, and the app already lets an admin point at a "fuller" external ffmpeg build for anyone who wants extra codecs and accepts the patent responsibility themselves. Happy to match whatever posture you prefer. |
mgallien
left a comment
There was a problem hiding this comment.
can you please fix the failing DCO check ?
For more information, have a look at the failing DCO CI check from the PR
see also our documentation here https://nextcloudappstore.readthedocs.io/en/latest/developer.html#obtaining-a-certificate
the requirements are on your own |
Signed-off-by: David Schneider <git@davidschneider.xyz>
appid would be matroskaplayer, to be inline with the release name of the library this is based on, which I released under the NPM Namespace @matroska-js
https://github.com/davidprojekt/matroska-player-nextcloud