fix: preserve MCP permissions scroll position - #1775
Merged
Conversation
Aaronontheweb
marked this pull request as ready for review
August 6, 2026 01:50
The new StateVersion subscribe lambda had no comment. Add one line that states why ToolGrid updates keep the scroll position. The test file had two blank lines before the new scroll test. Remove one line so the file uses a single blank line between tests.
Aaronontheweb
approved these changes
Aug 6, 2026
Aaronontheweb
left a comment
Aaronontheweb
left a comment
Collaborator
There was a problem hiding this comment.
LGTM - just added a Roslyn analyzer to Termina that will catch these types of issues in the future
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DynamicLayoutNodefor in-grid state changesNotes
Local targeted test execution was blocked by slow dependency compilation in this environment (
Netclaw.ActorsCoreCompile); opening as draft to let CI validate.