Fix xUnit discovery race in demo smoke tests - #1639
Merged
Aaronontheweb merged 3 commits intoJul 14, 2026
Merged
Conversation
Aaronontheweb
enabled auto-merge (squash)
July 14, 2026 19:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The Windows CI failure matches xunit/xunit#3576 exactly: xUnit 3.2.2 can append
Waiting 10 seconds for foreground threads to exit...to the assembly-info JSON consumed by the Visual Studio adapter, causing nondeterministic discovery failures. This is a runner protocol race, not a test timeout.Validation
-assemblyInfoinvocations emitted exactly one valid JSON objectNETCLAW_RUN_DEMO_SMOKE=1dotnet slopwatch analyzepassed with 0 issuespwsh ./scripts/Add-FileHeaders.ps1 -Verifypassedgit diff --checkpassedNo timeout values, sleeps, or retries were added.