Skip to content

Stabilize config search screenshot capture #1635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Aaronontheweb merged 2 commits into from
Jul 14, 2026
Merged

Stabilize config search screenshot capture #1635

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4637aaa
Stabilize config search screenshots
Aaronontheweb Jul 14, 2026
cc2d734
Merge branch 'dev' into fix/config-search-screenshot-race
Aaronontheweb Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions tests/smoke/tapes/screenshots/config-search.tape
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,21 +29,25 @@ Enter
# before the screenshot fires, capturing the wrong row.
Wait+Screen@10s /Choose the backend Netclaw uses for web search/
Wait+Screen@5s /DuckDuckGo works without setup/
Sleep 1s
Screenshot "/tmp/shot-config-search-selection.png"
Sleep 1s

# ─── Frame 2: Brave entry state ────────────────────────────────────────────
# SelectBackendForEditing("brave") is synchronous — Wait+Screen is sufficient.
# Wait+Screen confirms the view state; the settle guard lets Termina finish repainting.
Down
Enter
Wait+Screen@10s /Brave Search requires an API key/
Sleep 1s
Screenshot "/tmp/shot-config-search-brave-entry.png"
Sleep 1s

# ─── Frame 3: Saved state ──────────────────────────────────────────────────
# SaveWithoutProbeOverride cascades multiple ReactiveProperty notifications
# and a ReloadPersistedDraft disk read before the frame settles. A single
# Wait+Screen on the success text is not enough — a second anchor on the
# key-binding bar text guarantees both CurrentScreen==Saved and
# ActiveDialog==None have committed to a stable rendered frame.
# key-binding bar text confirms CurrentScreen==Saved and ActiveDialog==None; the
# settle guard then lets the resulting full refresh finish before capture.
# "[Enter] Settings Areas" is emitted by BuildKeyBindings only in that state
# (SearchConfigEditorPage.cs line 212).
Escape
Expand All @@ -57,6 +61,7 @@ Down 2
Enter
Wait+Screen@10s /validated and saved/
Wait+Screen@5s /\[Enter\] Settings Areas/
Sleep 1s
Screenshot "/tmp/shot-config-search-saved.png"

# Sleep 1s BEFORE Ctrl+Q: VHS's Screenshot is captured asynchronously on a
Expand Down
Loading