TASK: Raise PhpStan to level 8 - Part 2#3518
Merged
Merged
Conversation
mficzel
force-pushed
the
phpstanLevel8-v3-part2
branch
2 times, most recently
from
November 7, 2025 14:25
e4a16fd to
d8b7541
Compare
mficzel
force-pushed
the
phpstanLevel8-v3-part2
branch
13 times, most recently
from
November 7, 2025 18:25
569883c to
f422f3c
Compare
mficzel
force-pushed
the
phpstanLevel8-v3-part2
branch
from
November 7, 2025 18:41
f422f3c to
587ecda
Compare
mficzel
force-pushed
the
phpstanLevel8-v3-part2
branch
2 times, most recently
from
November 30, 2025 11:52
886f119 to
d9f48cc
Compare
mficzel
force-pushed
the
phpstanLevel8-v3-part2
branch
2 times, most recently
from
January 9, 2026 15:52
39aaae6 to
5ad6850
Compare
…tion context and remove breaking changes
mficzel
force-pushed
the
phpstanLevel8-v3-part2
branch
from
January 9, 2026 16:18
5ad6850 to
007bdd2
Compare
mficzel
marked this pull request as ready for review
January 9, 2026 16:28
6 tasks
mficzel
changed the title
kitsunet
reviewed
Jun 5, 2026
kitsunet
left a comment
kitsunet
left a comment
Member
There was a problem hiding this comment.
Making progress, still reading through it, but so far great
kdambekalns
reviewed
Jun 9, 2026
kdambekalns
left a comment
kdambekalns
left a comment
Member
There was a problem hiding this comment.
Generally: 🎉
I left a few comments, though. And the introduced \Exceptions make me sad, as they are overly generic. WDYT?
kitsunet
approved these changes
Jun 9, 2026
kitsunet
left a comment
kitsunet
left a comment
Member
There was a problem hiding this comment.
I think karstens comments are valid and should be included, but generally all fine
Co-authored-by: Karsten Dambekalns <karsten@dambekalns.de>
mficzel
force-pushed
the
phpstanLevel8-v3-part2
branch
from
June 11, 2026 16:31
5ca0492 to
c57f177
Compare
Member
|
Thank you all for pushing this and finalising it!!! :) <3 |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raise PhpStan to level 8 for:
This is a follow up for: #3515
Upgrade instructions
Review instructions
Follow ups will adjust the other Flow Subcontexts. This is limited to be in a manageble size.
Also the target branch should offcourse be adjusted to 9.2 once that exists.
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions