Remove designs that hide one exception to throw another

[neomatrix369]

A good example of this is this code block:

try {
        uriBuilder.build();
        this.apiReader = new APIReader(uriBuilder);
    } catch (APIKeyNotAssignedException e) { <<===
        logger.error(e.getMessage());                 <<===
        throw new IllegalStateException("No API Key assigned");
    }

in

https://github.com/carlosvillademor/RESTAPIUnifier/blob/master/java/src/main/java/org/neomatrix369/examples/muzutv/BaseMuzu.java

[carlosvillademor]

The initial exception is still available as we are logging it, but logging and throwing is problably not good either. I would say that this particular case where you have already a specific exception, you should throw that one. But when you have a more generic exception, like IOException or similar, it might be valid to throw a more specific exception to your domain.

[neomatrix369]

Yes agreed, lets do it that way.