SCHED-1943: Fix OpenTelemetry Collector JSON parsing errors for slurm_scripts#2690
Merged
Conversation
Uburro
marked this pull request as ready for review
July 3, 2026 07:26
theyoprst
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The jail-logs otel collector spams error-level logs with huge stacktraces:
invalid character '\u0000' looking for beginning of value. Check output files on the shared jail FS are truncated and rewritten in place bycheck_runner.py, so the collector (tailing from another node) can read partially flushed lines with zero-filled tails, and thejson_parserfails on them. Logs are still delivered — it's pure noise. Reproduces on some clusters (m42-h200, ami-labs) depending on storage/timing.Solution
Hardened the
parse_json_bodyoperator in the jail-logs collector config:ifguard to skip lines containing NUL bytes;on_error: send_quietso any other parse failure sends the entry unparsed and logs at debug instead of error.The parser is kept because it feeds
slurm_run_status/slurm_run_resolutionlog labels (added in #2125).Testing
make helmtesthelm template— verified the rendered operator config is valid and contains the new condition andon_error.Release Notes
Fix: jail-logs otel collector no longer emits error-level noise when reading partially flushed health check output files containing NUL bytes.