feat: Migrate cache from data.json to IndexedDB - #179
Merged
Conversation
Move the API response cache out of Obsidian's data.json (which gets synced) into IndexedDB (which stays local). This prevents cache data from bloating sync and keeps device-specific data where it belongs. - Replace in-memory Record-based RequestCache with IndexedDB-backed storage using the idb library, with an in-memory layer for fast synchronous reads - Remove periodic cache save interval (cacheIntervalSeconds setting) since IndexedDB persists on write - Add one-time migration: existing data.json cache entries are imported into IndexedDB, then cleared from data.json along with the legacy cacheIntervalSeconds setting - Preserve all existing cache behavior: TTL cleanup on startup (maxCacheAgeHours), request freshness checks (minRequestSeconds), and HTTP conditional requests (ETag/Last-Modified)
jdevera
force-pushed
the
feat/indexeddb-cache
branch
from
April 18, 2026 23:07
874dd32 to
a1ed9bf
Compare
|
nathonius
approved these changes
Aug 6, 2026
nathonius
left a comment
nathonius
left a comment
Owner
There was a problem hiding this comment.
Once again, looks great. And again, sorry for the delay.
|
Owner
|
@all-contributors please add @jdevera as a contributor for code |
Contributor
|
I've put up a pull request to add @jdevera! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #174
This PR moves the API response cache from
data.json(Obsidian's synced settings file) into IndexedDB, which stays local to the device.What changed
Record-basedRequestCachewith an IndexedDB-backed store using theidblibrary (~1KB, widely used by 20+ Obsidian plugins). An in-memory layer is kept on top for fast synchronous reads.cacheIntervalSecondssetting and thesetCacheInterval()timer are no longer needed.data.jsonare imported into IndexedDB, then cleared fromdata.json(along with the legacycacheIntervalSecondskey).maxCacheAgeHours), request freshness checks (minRequestSeconds), HTTP conditional requests (ETag/Last-Modified), and the "Clear cache" button in settings all work as before.What I tested
data.jsonno longer containscacheorcacheIntervalSecondsafter migration