Fix #15, Apply standard style - #23
Merged
Merged
Conversation
jphickey
previously requested changes
May 21, 2020
jphickey
left a comment
jphickey
left a comment
Contributor
There was a problem hiding this comment.
Note this is combining some short functions all into one line, which (IMO) is neither readable nor desirable. Can we tweak the settings so it doesn't do this?
Contributor
Author
|
See AllowShortFunctionsOnASingleLine on https://clang.llvm.org/docs/ClangFormatStyleOptions.html, feel free to modify nasa/cFS/.clang-format and reapply |
astrogeco
dismissed
jphickey’s stale review
May 28, 2020 14:18
Resolved in clang-format in the cfs repo. See nasa/cFS#88
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Whitespace changes only.
Fix #15
Testing performed
CI - https://travis-ci.com/github/skliper/cFS/builds/167637651
Expected behavior changes
None
System(s) tested on
Additional context
Note - not enforcing, just a single cleanup since there's no pending activity in this repo.
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC