[Maintenance] Remove undefined prop defaults#8369
Open
LarryHu0217 wants to merge 2 commits into
Open
Conversation
Addresses nasa#8352 by removing explicit undefined defaults from Vue props now that the vue/require-default-prop rule is disabled.
LarryHu0217
marked this pull request as ready for review
July 8, 2026 17:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8352
Describe your changes:
Remove explicit
default: undefinedentries from optional non-Boolean Vue props now thatvue/require-default-propis disabled. Those props still resolve toundefinedwhen omitted.Also remove the unused
isHeaderTitleBoolean prop fromTableColumnHeader.vue. Vue casts an omitted Boolean prop without an explicit default tofalse, so removing this dead prop avoids introducing that runtime semantic change.Testing:
rg -n "default:\\s*undefined|default\\s*\\(\\)\\s*\\{\\s*return\\s+undefined|default:\\s*void\\s+0" src example e2ereturned no matchesnpm run buildnpm test— 975 passed, 67 skippedgit diff --checkAll Submissions:
Author Checklist
type:label? Maintainer permissions are required.Reviewer Checklist