Skip to content

Fix #517, require active keys for verification - #526

Open
sylvesterkaczmarek wants to merge 1 commit into
nasa:devfrom
sylvesterkaczmarek:fix-517-key-verify-active-state
Open

Fix #517, require active keys for verification#526
sylvesterkaczmarek wants to merge 1 commit into
nasa:devfrom
sylvesterkaczmarek:fix-517-key-verify-active-state

Conversation

@sylvesterkaczmarek

Copy link
Copy Markdown

Reject SDLS Key Verification requests when a requested key is not in KEY_ACTIVE state, matching the key verification procedure requirements.

Update the existing successful verification vectors to make their ACTIVE-key precondition explicit and add focused coverage proving a PREACTIVE key returns CRYPTO_LIB_ERR_KEY_STATE_INVALID.

Validation: CryptoLib extended-procedure build and full EP test suite pass in the project container.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?

How do you test these changes?

Reject SDLS Key Verification requests when a requested key is not in KEY_ACTIVE state, matching the key verification procedure requirements.

Update the existing successful verification vectors to make their ACTIVE-key precondition explicit and add focused coverage proving a PREACTIVE key returns CRYPTO_LIB_ERR_KEY_STATE_INVALID.

Validation: CryptoLib extended-procedure build and full EP test suite pass in the project container.
@sylvesterkaczmarek
sylvesterkaczmarek marked this pull request as ready for review August 16, 2026 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant