Fix #517, require active keys for verification - #526
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
Conversation
Reject SDLS Key Verification requests when a requested key is not in KEY_ACTIVE state, matching the key verification procedure requirements. Update the existing successful verification vectors to make their ACTIVE-key precondition explicit and add focused coverage proving a PREACTIVE key returns CRYPTO_LIB_ERR_KEY_STATE_INVALID. Validation: CryptoLib extended-procedure build and full EP test suite pass in the project container.
sylvesterkaczmarek
marked this pull request as ready for review
August 16, 2026 09:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject SDLS Key Verification requests when a requested key is not in KEY_ACTIVE state, matching the key verification procedure requirements.
Update the existing successful verification vectors to make their ACTIVE-key precondition explicit and add focused coverage proving a PREACTIVE key returns CRYPTO_LIB_ERR_KEY_STATE_INVALID.
Validation: CryptoLib extended-procedure build and full EP test suite pass in the project container.
All Submissions:
New Feature Submissions:
Changes to Core Features:
How do you test these changes?