Skip to content

fix: update log for place details#1445

Merged
prakharritik merged 1 commit into
mainfrom
place-details-api-changes
Jul 24, 2026
Merged

fix: update log for place details#1445
prakharritik merged 1 commit into
mainfrom
place-details-api-changes

Conversation

@prakharritik

@prakharritik prakharritik commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates

Description

Additional Changes

  • This PR modifies the database schema (database migration added)
  • This PR modifies dhall configs/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code and addressed linter errors ./dev/format-all-files.sh
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

Summary by CodeRabbit

  • Enhancements
    • Improved external map API request logging with structured details, including place ID, session token, requested fields, and request URL.

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: bc079640-9dd9-4bed-8b56-aa67ce534ab3

📥 Commits

Reviewing files that changed from the base of the PR and between 2a806ec and 840386c.

📒 Files selected for processing (1)
  • lib/mobility-core/src/Kernel/External/Maps/Google/MapsClient.hs

Walkthrough

getPlaceDetailsV2 now logs a structured JSON request containing the place ID, session token, field mask, and Google Maps URL instead of logging only the place ID.

Changes

Google Maps logging

Layer / File(s) Summary
Structured place-details request logging
lib/mobility-core/src/Kernel/External/Maps/Google/MapsClient.hs
Adds qualified Aeson support and sends structured request metadata to the Kafka external API logger.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Poem

A rabbit hops where map calls flow,
With fields and tokens all aglow.
The place ID joins the URL trail,
Kafka records the fuller tale.
Hop, hop—structured logs prevail!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: updating logging for place details requests.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch place-details-api-changes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@prakharritik
prakharritik merged commit feff2b1 into main Jul 24, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants