fix(android): guard MapView.addFeature against re-parenting non-map c…#31
Merged
witcher-shailesh merged 1 commit intoApr 29, 2026
Merged
Conversation
…hildren The catch-all branch in MapView.addFeature() called addView(child, index) without first removing the child from any existing parent, producing "The specified child already has a parent" IllegalStateException on Fabric re-mounts. Mirror the existing guard used for the MapMarker branch, and iterate ViewGroup children in reverse so removals during recursion don't shift indices.
witcher-shailesh
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…hildren
The catch-all branch in MapView.addFeature() called addView(child, index) without first removing the child from any existing parent, producing "The specified child already has a parent" IllegalStateException on Fabric re-mounts. Mirror the existing guard used for the MapMarker branch, and iterate ViewGroup children in reverse so removals during recursion don't shift indices.
Does any other open PR do the same thing?
(please answer here)
What issue is this PR fixing?
(please link the issue here)
How did you test this PR?
(please answer here)