Skip to content

Enable library evolution#1143

Closed
pepone wants to merge 1 commit into
mxcl:masterfrom
pepone:library-evolution
Closed

Enable library evolution#1143
pepone wants to merge 1 commit into
mxcl:masterfrom
pepone:library-evolution

Conversation

@pepone

@pepone pepone commented Apr 30, 2020

Copy link
Copy Markdown

Hi,

This PR enables "Library Evolution" support

See https://swift.org/blog/abi-stability-and-more/

We (ZeroC) are trying to enable this for zeroc-ice/ice but we are getting errors because PromiseKit doesn't enable it.

error: module 'PromiseKit' was not compiled with library evolution support; using it means binary compatibility for 'Ice' can't be guaranteed
import PromiseKit

It will be nice if this can be merge and get Library Evolution enabled for the next PromiseKit release.

I think this will also solve #1137
Cheers,
José

@martinpucik

Copy link
Copy Markdown

I don't think this should be enabled for PromiseKit, afaik BUILD_LIBRARY_FOR_DISTRIBUTION is not intended for libraries distributed via e.g. Cocoapods and embeded inside the app.
More about this in conversation from CocoaPods/CocoaPods#9232 (comment)

#1137 should be resolved by running carthage bootstrap, similar issue discussed here airbnb/lottie-ios#1173 (comment)

@RomanPodymov

RomanPodymov commented May 19, 2020

Copy link
Copy Markdown
Collaborator

Hello @pepone
I think this pull request is a duplicate of #1117.

@pepone

pepone commented May 19, 2020

Copy link
Copy Markdown
Author

Hi @RomanPodymov

Thanks I miss that, I closing this

@pepone pepone closed this May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants