You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@m4theushw I removed the event and props on some of the custom cell renderers because the typing says that they should not be here.
I would like your confirmation on this point 👍
Follow up on #2189 (comment)
If we want to stop exposing apiRef, I suppose that we don't want to type it on the public methods while it's still their.
The columns / colDef typing is still relevant I think.
@oliviertassinari the type-only import ( import type { MyType } ) handles circular imports perfectly from what I read.
I'm not sure if, when importing a type with import { MyType } there is a real circular import issue or if it's just a limitation of the ESLint rule.
@flaviendelangle Ok, I didn't know that TypeScript support circular type declaration. It sounds interesting to give it a try and see if it fly at scale or not. At least, we would have found and fixed other issues in the codebase.
flaviendelangle
changed the title
[typescript] Avoid untyped colDef property
[typescript] Avoid untyped colDef and api properties (except for soon to be removed api)
Aug 4, 2021
oliviertassinari
changed the title
[typescript] Avoid untyped colDef and api properties (except for soon to be removed api)
[typescript] Improve type coverage of colDef
Aug 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2187
Other public methods that are not typed
onStateChangeis not typed (but may be removed [docs] Add missing API docs #2167)