feat(chat): OnStepContent callback — surface the model's between-tool…#52
Merged
Conversation
…s commentary in order
Bump cogito to 3c90863, which stops leaking raw tool results (and other
model content) through the status callback — the leak that made chat UIs
render every tool result twice, once as an unbounded unstyled "status" —
and adds WithStepContentCallback for the assistant text that accompanies
a tool selection ("I'll search for X now…"), previously dropped outright.
- chat: new optional Callbacks.OnStepContent, wired to cogito's
WithStepContentCallback; fires at the step boundary before the selected
tools run, so consumers can commit the commentary chronologically
relative to OnToolResult (text → tool result → … → final answer).
- cli: print step commentary dim, in-place, before the tool it announced.
- test: TestStepContentReachesCallbackBeforeToolResult drives a fake
OpenAI server through a commentary+ask_user step and asserts the
cross-callback order.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…s commentary in order
Bump cogito to 3c90863, which stops leaking raw tool results (and other model content) through the status callback — the leak that made chat UIs render every tool result twice, once as an unbounded unstyled "status" — and adds WithStepContentCallback for the assistant text that accompanies a tool selection ("I'll search for X now…"), previously dropped outright.