fix(model): do not assume success when deleting a model process#7963
Merged
mudler merged 3 commits intomudler:masterfrom Jan 10, 2026
Merged
fix(model): do not assume success when deleting a model process#7963mudler merged 3 commits intomudler:masterfrom
mudler merged 3 commits intomudler:masterfrom
Conversation
✅ Deploy Preview for localai ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: Jon Roeber <jon@roeber.dev>
jroeber
force-pushed
the
fix-model-deletion-assumption
branch
from
47b87a0 to
d2aa24e
Compare
mudler
reviewed
Jan 10, 2026
Co-authored-by: Ettore Di Giacinto <mudler@users.noreply.github.com> Signed-off-by: Jon Roeber <65431671+jroeber@users.noreply.github.com>
mudler
approved these changes
Jan 10, 2026
Owner
|
good catch, thanks! |
localai-bot
pushed a commit
to localai-bot/LocalAI
that referenced
this pull request
Mar 25, 2026
…er#7963) * fix(model): do not assume success when deleting a model process Signed-off-by: Jon Roeber <jon@roeber.dev> * Update pkg/model/process.go Co-authored-by: Ettore Di Giacinto <mudler@users.noreply.github.com> Signed-off-by: Jon Roeber <65431671+jroeber@users.noreply.github.com> --------- Signed-off-by: Jon Roeber <jon@roeber.dev> Signed-off-by: Jon Roeber <65431671+jroeber@users.noreply.github.com> Co-authored-by: Ettore Di Giacinto <mudler@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #7962
Notes for Reviewers
Related: #7958
Signed commits