fix(backends): whisper darwin run.sh loads whichever fallback lib exists (.so/.dylib)#10553
Merged
Conversation
The macOS branch hardcoded WHISPER_LIBRARY=$CURDIR/libgowhisper-fallback.dylib,
but the cmake build emits a Mach-O named libgowhisper-fallback.so on darwin, so
the Go loader panicked at runtime ("dlopen ...dylib: no such file") and the
backend exited ("grpc service not ready") — breaking e.g. the silero-vad-ggml
VAD on darwin. Pick whichever of .dylib/.so is present so it is robust to the
build's naming either way.
Assisted-by: Claude:claude-opus-4-8
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
whisper's darwin build/image is correct (after #10541), but the backend still panics at load on macOS:
Cause:
run.sh's Darwin branch hardcodesWHISPER_LIBRARY=$CURDIR/libgowhisper-fallback.dylib, but the cmake build emits a Mach-O namedlibgowhisper-fallback.soon darwin. The Go loaderdlopens the non-existent.dylib→ panic → backend exits →grpc service not ready. This breaks e.g. the realtime silero-vad-ggml VAD (which runs on whisper.cpp) on macOS.Fix
Darwin branch picks whichever fallback lib exists (
.dylibelse.so), so it's robust regardless of how the build names it.Verified against the real darwin whisper package (only
libgowhisper-fallback.sopresent) — the binary now resolves it.bash -nclean; Linux path untouched.🤖 Generated with Claude Code