Skip to content

fix(distributed): missing agent NATS permission#10549

Merged
mudler merged 1 commit into
mudler:masterfrom
ALameLlama:fix/nats-permission
Jun 27, 2026
Merged

fix(distributed): missing agent NATS permission#10549
mudler merged 1 commit into
mudler:masterfrom
ALameLlama:fix/nats-permission

Conversation

@ALameLlama

@ALameLlama ALameLlama commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

Description

This PR fixes #10548

Notes for Reviewers
There might still be other missing permissions but this is the only one that I've run into so far

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Nicholas Ciechanowski <nicholas@ciech.anow.ski>
@ALameLlama
ALameLlama force-pushed the fix/nats-permission branch from 47d000c to 0f5a93a Compare June 27, 2026 08:17
@ALameLlama

Copy link
Copy Markdown
Contributor Author

Actually I eventually got another one for staging.*.progress which I think is from here

const SubjectStagingProgressWildcard = "staging.*.progress"

is there a better way to try and get all the NAT permissions? or are we gonna need to just find them all in the code base?

@mudler mudler left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@mudler

mudler commented Jun 27, 2026

Copy link
Copy Markdown
Owner

Actually I eventually got another one for staging.*.progress which I think is from here

const SubjectStagingProgressWildcard = "staging.*.progress"

is there a better way to try and get all the NAT permissions? or are we gonna need to just find them all in the code base?

the constant is used as a wildcard here, so there is no strict enforcement in the code to the name events. We could go back and do have specific naming to track these in the code, which probably would make more sense too.

@mudler
mudler enabled auto-merge (squash) June 27, 2026 20:37
@mudler
mudler merged commit c548150 into mudler:master Jun 27, 2026
58 checks passed
@ALameLlama
ALameLlama deleted the fix/nats-permission branch June 28, 2026 00:40
@ALameLlama
ALameLlama restored the fix/nats-permission branch June 28, 2026 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NATS permission error for agent worker

2 participants