fix(backends): repair release CI build/test breaks (kokoros, fish-speech, llama-cpp-quantization, sglang)#10547
Merged
Merged
Conversation
The backend.proto grew six RPCs (SoundDetection, Depth, TokenClassify,
Score and the bidi-streaming Forward) that the kokoros gRPC service never
implemented, so the trait impl no longer satisfies `Backend`:
error[E0046]: not all trait items implemented, missing:
`sound_detection`, `depth`, `token_classify`, `score`,
`ForwardStream`, `forward`
kokoros is a TTS backend with no use for these, so add `unimplemented`
stubs (plus the `ForwardStream` associated type) matching the existing
pattern for every other unsupported RPC in this file.
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
Assisted-by: Claude:claude-opus-4-8 [Claude Code]
install.sh installs the fish-speech source tree editable with
`--no-build-isolation`, which means the build backends of its transitive
dependencies must already be present in the venv. One of them builds a
Rust extension and its metadata step fails with:
ModuleNotFoundError: No module named 'setuptools_rust'
Add setuptools-rust to requirements.txt so installRequirements provisions
it before the editable install runs.
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
Assisted-by: Claude:claude-opus-4-8 [Claude Code]
…sion/
Upstream llama.cpp split the model-specific logic out of the single
convert_hf_to_gguf.py file into a sibling `conversion/` package, so the
script now starts with `from conversion import ...`. Downloading just the
one file therefore fails at runtime with:
ModuleNotFoundError: No module named 'conversion'
Clone the repo (reusing the clone already needed to build llama-quantize)
and copy both the script and the `conversion/` package into the backend
dir. Python puts the script's own directory on sys.path[0], so the package
resolves when it sits beside the script.
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
Assisted-by: Claude:claude-opus-4-8 [Claude Code]
The CPU profile builds sgl-kernel from a `git clone` of sglang with no
ref, so it always tracks master. Recent master added CPU kernels (e.g.
mamba/fla.cpp) that fail to compile in our builder:
constexpr variable 'scale' must be initialized by a constant
static library kineto_LIBRARY-NOTFOUND not found
Pin the clone to v0.5.11, the same release the GPU path already floors on
(requirements-cublas12-after.txt). Overridable via SGLANG_VERSION so the
pin can be bumped deliberately.
Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
Assisted-by: Claude:claude-opus-4-8 [Claude Code]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes the four genuine build/test breaks observed in the v4.5.4 release CI (in the still-running
build backend container imagesandTests extras backendsworkflows). One commit per backend.error[E0046]: not all trait items implemented, missing: sound_detection, depth, token_classify, score, ForwardStream, forwardbackend.protogrew 6 RPCs the TTS service never implemented. Addedunimplementedstubs + theForwardStreamassociated type, matching the existing pattern for every other unsupported RPC in the file.ModuleNotFoundError: No module named 'setuptools_rust'during editable metadata generationinstall.shinstalls the source tree with--no-build-isolation, so a transitive dep's Rust build backend must already be in the venv. Addedsetuptools-rusttorequirements.txt.convert_hf_to_gguf.py failed→ModuleNotFoundError: No module named 'conversion'conversion/package, soconvert_hf_to_gguf.pynow doesfrom conversion import .... The single-file download no longer runs. Now clone the repo (reusing the clone already needed forllama-quantize) and copy both the script and theconversion/package beside each other.constexpr variable 'scale' must be initialized by a constant/kineto_LIBRARY-NOTFOUNDinmamba/fla.cppsglangmaster unpinned. Pinned the source clone tov0.5.11(the floor the GPU path already uses), overridable viaSGLANG_VERSION.Not addressed (transient infra)
Two other v4.5.4 job failures were Docker Hub / CloudFront timeouts (
vibevoicecublas build,pocket-ttsmerge) — not code issues, just need a re-run.Verification
cargo checkwasn't possible (vendoredkokorossubmodule + noprotocin this env) — the backend image build in CI compiles it.Tests extras backendsjobs in CI.Assisted-by: Claude:claude-opus-4-8 [Claude Code]