fix(backends): darwin packaging for silero-vad (last Linux-only Go backend)#10528
Merged
Conversation
silero-vad was the last Go backend with Linux-only darwin packaging: - package.sh fell through to "Could not detect architecture" -> exit 1 on macOS (no Darwin branch), so its darwin image never packaged. - run.sh exported LD_LIBRARY_PATH, which macOS dyld ignores, so the bundled libonnxruntime.dylib couldn't be found at runtime. Add a Darwin branch to package.sh (skip the glibc/ld.so bundling; add an @loader_path/lib rpath so @rpath resolves to package/lib/) and a DYLD_LIBRARY_PATH branch to run.sh — mirroring the piper darwin fix (#10525). Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
mudler
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A sweep of all
backend/go/*backends found silero-vad is the last one with Linux-only darwin packaging (every other Go backend already has Darwin branches):package.shhad no Darwin branch → fell through to"Could not detect architecture" → exit 1on macOS, so itsmetal-darwin-arm64-silero-vadimage never packaged.run.shexportedLD_LIBRARY_PATH(ignored by macOS dyld), so the bundledlibonnxruntime.dylibwasn't found at runtime.Fix (mirrors the piper darwin fix #10525)
package.sh: Darwin branch that skips the glibc/ld.sobundling and addsinstall_name_tool -add_rpath @loader_path/libso@rpathresolves topackage/lib/.run.sh:DYLD_LIBRARY_PATHbranch on Darwin.Testing
bash -nclean on both scripts; Linux packaging paths unchanged (Darwin branch precedes them). Darwin build validated in CI.🤖 Generated with Claude Code