player/command: refactor loadfile and loadlist commands to use flags - #16837
Merged
Conversation
Dudemanguy
force-pushed
the
loadfile-flags
branch
from
September 26, 2025 17:25
ab7f819 to
7c0dbe4
Compare
Member
|
I even recall having such patch somewhere. |
sfan5
reviewed
Sep 29, 2025
| immediately start playback even if the playlist was previously empty. Adding | ||
| the ``play`` flag to them forces playback to start. | ||
|
|
||
| The following arguments are considered deprecated and were the old way |
Member
There was a problem hiding this comment.
arguments? the insertion index and option list are not deprecated.
Member
Author
There was a problem hiding this comment.
"values" is the better word to use here.
Dudemanguy
force-pushed
the
loadfile-flags
branch
from
September 29, 2025 14:48
7c0dbe4 to
7c71d9a
Compare
kasper93
approved these changes
Jan 7, 2026
Member
Author
|
Yeah been meaning to actually do a few tests and rebasing it later. Should hopefully get to that this week. |
We should have done this ages ago. These commands essentially consist of a combination of a load action and whether or not playback should be started. The old `-play` aliases are kept for backwards compatibility.
Dudemanguy
force-pushed
the
loadfile-flags
branch
from
January 10, 2026 00:36
7c71d9a to
76bf04e
Compare
Member
Author
|
Finally got around to testing it. Works as expected on my end. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should have done this ages ago. These commands essentially consist of a combination of a load action and whether or not playback should be started. The old
-playaliases are kept for backwards compatibility.Didn't thoroughly test or anything yet.