Bug 2057561 - Caching derived scatter data (Fix 2) - #9750
Open
davidmiculit wants to merge 3 commits into
Open
Conversation
davidmiculit
requested review from
beatrice-acasandrei and
esanuandra
as code owners
August 3, 2026 10:38
✅ Deploy Preview for treeherder ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
davidmiculit
force-pushed
the
feat/2057561-fix2
branch
from
August 3, 2026 10:52
8cdd3d7 to
808f816
Compare
esanuandra
reviewed
Aug 4, 2026
Collaborator
|
There could be some stale-cache bugs, waiting on confirmation for that. |
esanuandra
reviewed
Aug 12, 2026
| if (prevProps.testData !== testData || prevProps.changelogData !== changelogData) { | ||
| this.updateGraphs(); | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
Having the changelogData verified here affects and resets the zoom if the user started using it until the changelogData request finishes.
The changelogData affects only the infraAffectedData, no need to rebuild the whole graph.
Suggested change
| if (prevProps.testData !== testData) { | |
| this.updateGraphs(); // full rebuild only when the data changes | |
| } | |
| if (prevProps.changelogData !== changelogData) { | |
| this.setState((state) => ({ | |
| infraAffectedData: this.computeInfraAffectedData(state.scatterPlotData, changelogData), | |
| })); // targeted: no zoom reset, no cache rebuild | |
| } | |
| }; | ||
|
|
||
| computeInfraAffectedData = (scatterPlotData, changelogData = []) => { | ||
| let rawInfraData = []; |
Collaborator
There was a problem hiding this comment.
Suggested change
| let rawInfraData = []; | |
| const rawInfraData = []; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug 2057561 - Improve frontend performance on Graphs View
The render method previously executed expensive
flatMap/forEach/slicechains and O(N) array traversals on every state change, severely bottlenecking performance during graph hover and highlight events.Fix:
infraAffectedDatacomputation out ofrender, recalculating it only whentestDataorchangelogDataexplicitly change.scatterPlotMapto instantly resolve hovered and locked data points, replacing expensive.find()lookups.componentDidUpdate.Before:
After:
