This repository was archived by the owner on Apr 3, 2019. It is now read-only.
feat(test): Test on node 10 - #2716
Closed
shane-tomlinson wants to merge 1 commit into
Closed
Conversation
ghost
assigned
Author
|
This is failing because scrypt-hash needs its dependencies updated. I have started a WIP PR |
Contributor
|
Node v10.5.0 includes a build-in scrypt function which may be useful to us: |
Contributor
Oh amazing!!! |
Author
That's what I thought too until I tried using node-10's built in s-crypt and kept getting out of memory errors. Some parameter tweaking may be needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's see if this works.
@mozilla/fxa-devs - r?