Upgrade to React 18 - #1438
Merged
Merged
Conversation
mattgperry
commented
Feb 2, 2022
| element.mount({}) | ||
| return element.unmount() | ||
| }, []) | ||
| return element.unmount |
Collaborator
Author
There was a problem hiding this comment.
This isn't React 18 specific, but something that must have been a quiet bug before
|
Awesome thank you @mattgperry 👍 |
mattgperry
force-pushed
the
feature/18
branch
from
February 9, 2022 11:33
c0487ed to
96a65ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes Framer Motion compatible with React 18.
I've downgraded it back to 17 in resolutions as it wasn't compatible with all test suites.
The biggest change is that components can be re-mounted, so they can't consider an unmount the same as the end of their lifecycle.
Closes #826