Remove Electron container support (deprecation) - #868
Open
bingenito wants to merge 4 commits into
Open
Conversation
desktopjs-electron is being deprecated. Removes the package, its example app, and every build/lint/docs/IDE reference so the monorepo no longer ships or exercises Electron-specific code. This also closes the Electron-only security findings (F#07, F#09, F#11, F#12) and the RCE chains that terminated in its executeJavaScript/ipcMain sinks, since those sinks no longer exist. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #868 +/- ##
===========================================
+ Coverage 74.03% 90.46% +16.42%
===========================================
Files 16 15 -1
Lines 1510 1122 -388
Branches 318 234 -84
===========================================
- Hits 1118 1015 -103
+ Misses 386 102 -284
+ Partials 6 5 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR completes the Electron deprecation by removing the desktopjs-electron workspace/package and the Electron example app, and scrubbing Electron-specific references from build, docs, examples, and IDE configuration across the monorepo.
Changes:
- Removed the
packages/desktopjs-electronworkspace (source, tests, configs, README) and theexamples/electrondemo. - Removed Electron references from monorepo tooling/configuration (workspaces, TypeDoc, ESLint overrides, VS Code launch configs, web example HTML/assets).
- Updated remaining docs/comments/tests in
desktopjsto be container-agnostic (e.g., wndproc hooking wording, shortcut docs).
Reviewed changes
Copilot reviewed 24 out of 25 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| vite.config.ts | Drops Electron Rollup externalization now that Electron support is removed. |
| typedoc.json | Removes Electron package entry point from generated API docs. |
| packages/desktopjs/tests/unit/window.spec.ts | Renames SnapAssist test wording to remove Electron-specific reference. |
| packages/desktopjs/src/window.ts | Updates comment to describe container/native wndproc hook behavior generically. |
| packages/desktopjs/src/shortcut.ts | Removes Electron “Accelerator” doc link; replaces with generic accelerator-string description. |
| packages/desktopjs/src/registry.ts | Updates container registry doc example away from Electron. |
| packages/desktopjs/package.json | Removes “electron” keyword from package metadata. |
| packages/desktopjs-electron/vite.config.ts | Deleted (Electron package removal). |
| packages/desktopjs-electron/tsconfig.json | Deleted (Electron package removal). |
| packages/desktopjs-electron/tests/setup.ts | Deleted (Electron package removal). |
| packages/desktopjs-electron/tests/electron.spec.ts | Deleted (Electron package removal). |
| packages/desktopjs-electron/src/electron.ts | Deleted (Electron package removal). |
| packages/desktopjs-electron/README.md | Deleted (Electron package removal). |
| packages/desktopjs-electron/package.json | Deleted (Electron package removal). |
| packages/desktopjs-electron/jest.config.js | Deleted (Electron package removal). |
| package.json | Removes Electron workspace(s) from npm workspaces list. |
| package-lock.json | Updates workspace list, but still retains stale entries for removed Electron workspace/example. |
| examples/web/index.html | Removes loading of Electron UMD bundle from the web example. |
| examples/web/assets/js/app.js | Removes Electron-notification polyfill example snippet. |
| examples/README.md | Removes Electron example link from examples index. |
| examples/electron/README.md | Deleted (Electron example removal). |
| examples/electron/package.json | Deleted (Electron example removal). |
| examples/electron/electron.js | Deleted (Electron example removal). |
| eslint.config.mjs | Removes Electron-source-file-specific lint override. |
| .vscode/launch.json | Removes Electron debug launch configurations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bingenito
marked this pull request as ready for review
August 3, 2026 17:58
bingenito
enabled auto-merge
August 3, 2026 17:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
desktopjs-electronpackage, its example app, and every build/lint/docs/IDE reference to Electron from the monorepo.