Skip to content

multi-branch support: detect distDir instead of reconstructing - #274

Merged
redstonekasi merged 3 commits into
moonlight-mod:mainfrom
slonkazoid:multi-branch
Nov 23, 2025
Merged

multi-branch support: detect distDir instead of reconstructing#274
redstonekasi merged 3 commits into
moonlight-mod:mainfrom
slonkazoid:multi-branch

Conversation

@slonkazoid

@slonkazoid slonkazoid commented Aug 11, 2025

Copy link
Copy Markdown
Contributor

Comment thread packages/core-extensions/src/moonbase/native.ts
Comment thread packages/core-extensions/src/moonbase/native.ts

@redstonekasi redstonekasi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine for now, strictly speaking getDistDir shouldn't be implemented at all for the browser, but that code is badly in need of a cleanup anyway, and can wait until then.

@redstonekasi
redstonekasi merged commit 2127003 into moonlight-mod:main Nov 23, 2025
2 checks passed
@NotNite

NotNite commented Nov 23, 2025

Copy link
Copy Markdown
Member

It seems like this PR wasn't tested at all (not a knock on Kasi, I'm sure he's tired) - in the future, please test your PRs before creating them (or at least mark them as a draft): 1743b3b 7860397

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants