Allow valid SRV hostnames with less than 3 parts - #1525
Merged
Conversation
NathanQingyangXu
force-pushed
the
JAVA-5542
branch
from
October 5, 2024 00:23
63c5ffe to
86b3b81
Compare
NathanQingyangXu
marked this pull request as ready for review
October 7, 2024 20:23
NathanQingyangXu
requested review from
a team and
rozza
and removed request for
a team
October 7, 2024 20:23
NathanQingyangXu
marked this pull request as draft
October 7, 2024 21:17
NathanQingyangXu
force-pushed
the
JAVA-5542
branch
3 times, most recently
from
October 9, 2024 01:43
c3d2782 to
36811a2
Compare
NathanQingyangXu
force-pushed
the
JAVA-5542
branch
from
October 9, 2024 01:54
36811a2 to
49ee4c4
Compare
NathanQingyangXu
marked this pull request as ready for review
October 9, 2024 04:31
jyemin
requested review from
katcharov and
vbabanin
and removed request for
vbabanin
October 9, 2024 11:50
katcharov
requested changes
Oct 18, 2024
katcharov
left a comment
katcharov
left a comment
Collaborator
There was a problem hiding this comment.
Looking good, just a few comments/questions.
…redundant code comment as per code review comment
…at 'resolvedHost' might not contain '.'
NathanQingyangXu
force-pushed
the
JAVA-5542
branch
from
October 21, 2024 19:07
9535d5d to
fb9feb5
Compare
katcharov
approved these changes
Oct 24, 2024
| ':' in between, as expected by ServerAddress. | ||
|
|
||
| It's required that the srvHost has at least three parts (e.g. foo.bar.baz) and that all of the resolved hosts have a parent | ||
| domain equal to the domain of the srvHost. |
Collaborator
There was a problem hiding this comment.
Optional since this is internal, but consider replacing this with the revised conditions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/JAVA-5542