Skip to content

feat(mojaloop/#2092): upgraded node version and refactored postman functional tests - #215

Merged
vijayg10 merged 34 commits into
mojaloop:masterfrom
vijayg10:feat/upgrade-node-version
Jul 28, 2022
Merged

vijayg10 merged 34 commits into
mojaloop:masterfrom
vijayg10:feat/upgrade-node-version

Conversation

@vijayg10

@vijayg10 vijayg10 commented Jul 21, 2022 •

Copy link
Copy Markdown
Contributor

feat(mojaloop/#2092): upgrade nodeJS version for core services - mojaloop/project#2092

  • Upgrade to node v16
  • Update packages/linting/audit/dockerfile
  • Update ci with dep/audit checks
  • Installed pre-commit hooks
  • refactored postman functional tests

Notes:

  • Helm chart mountPaths need to be updated from /opt/mojaloop-testing-toolkit to /opt/app as follows:
        volumeMounts:
        - mountPath: /opt/app/config
          name: <deployment-name>

BREAKING CHANGE: Major version bump for node v16 LTS support, re-structuring of project directories to align to core Mojaloop repositories and docker image now uses /opt/app instead of /opt/mojaloop-testing-toolkit which will impact config mounts, and changed the port number from 5000 to 4040 which will impact the values in TTK environment files used in test executions and helm values files used in K8S deployments.

Major version bump since this is a big upgrade.

…older structure

BREAKING CHANGE: Upgraded node version to v16
@vijayg10
vijayg10 marked this pull request as ready for review July 25, 2022 14:32
@vijayg10
vijayg10 requested a review from mdebarros July 25, 2022 14:32

@mdebarros mdebarros left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated your PR description.

See my comments...

Additional comments for your attention

  • Please include missing breaking changes in PR BREAKING CHANGES: section, such as /opt/app folder change, port-mapping changes, etc.

Comment thread Dockerfile Outdated
Comment thread docker-compose.yml Outdated
Comment thread docker-compose.yml Outdated
Comment thread docker/hosted-mode-tls/docker-compose.yaml Outdated
Comment thread docker/hosted-mode-tls/docker-compose.yaml Outdated
Comment thread docker/hosted-mode/docker-compose.yaml Outdated
Comment thread package.json Outdated
Comment thread simulator/scheme-adapter.env Outdated
Comment thread simulator2/scheme-adapter.env Outdated
Comment thread test/func/docker-compose.yml Outdated
Co-authored-by: Miguel de Barros <miguel@debarros.me>
@mdebarros mdebarros changed the title feat: upgraded node version and refactored postman functional tests feat(mojaloop/#2092): upgraded node version and refactored postman functional tests Jul 25, 2022
@vijayg10
vijayg10 requested a review from mdebarros July 25, 2022 16:04

@mdebarros mdebarros left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, I found some minor follow-up changes.

P.s. please don't forget to update the BREAKING CHANGES in the PR/Commit description.

Comment thread Dockerfile Outdated
Comment thread simulator/scheme-adapter.env Outdated
Comment thread simulator/scheme-adapter.env Outdated
vijayg10 and others added 2 commits July 25, 2022 23:09
Co-authored-by: Miguel de Barros <miguel@debarros.me>
Co-authored-by: Miguel de Barros <miguel@debarros.me>
Co-authored-by: Miguel de Barros <miguel@debarros.me>

@mdebarros mdebarros left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its looking good...some very minor suggested changes

Comment thread package.json Outdated
Comment thread test/func/postman/ttk_func_collection.json
Comment thread test/func/postman/ttk_func_collection.json
@vijayg10
vijayg10 merged commit 4ac6f40 into mojaloop:master Jul 28, 2022
@vijayg10
vijayg10 deleted the feat/upgrade-node-version branch July 28, 2022 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants