feat(mojaloop/#2092): upgraded node version and refactored postman functional tests - #215
Merged
Merged
Conversation
…older structure BREAKING CHANGE: Upgraded node version to v16
18 tasks
added 12 commits
July 21, 2022 15:30
vijayg10
marked this pull request as ready for review
July 25, 2022 14:32
mdebarros
requested changes
Jul 25, 2022
Co-authored-by: Miguel de Barros <miguel@debarros.me>
Co-authored-by: Miguel de Barros <miguel@debarros.me>
…10/ml-testing-toolkit into feat/upgrade-node-version
mdebarros
requested changes
Jul 25, 2022
mdebarros
left a comment
Member
There was a problem hiding this comment.
Thanks for the updates, I found some minor follow-up changes.
P.s. please don't forget to update the BREAKING CHANGES in the PR/Commit description.
Co-authored-by: Miguel de Barros <miguel@debarros.me>
Co-authored-by: Miguel de Barros <miguel@debarros.me>
Co-authored-by: Miguel de Barros <miguel@debarros.me>
mdebarros
reviewed
Jul 26, 2022
mdebarros
left a comment
Member
There was a problem hiding this comment.
Its looking good...some very minor suggested changes
added 11 commits
July 26, 2022 15:31
…10/ml-testing-toolkit into feat/upgrade-node-version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(mojaloop/#2092): upgrade nodeJS version for core services - mojaloop/project#2092
Notes:
/opt/mojaloop-testing-toolkitto/opt/appas follows:BREAKING CHANGE: Major version bump for node v16 LTS support, re-structuring of project directories to align to core Mojaloop repositories and docker image now uses
/opt/appinstead of/opt/mojaloop-testing-toolkitwhich will impact config mounts, and changed the port number from 5000 to 4040 which will impact the values in TTK environment files used in test executions and helm values files used in K8S deployments.Major version bump since this is a big upgrade.